[FIX] [13.0] pos_payment_terminal: directly switch to 'waiting for card', prevent endless status polling #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaspaulb
commented
Jul 17, 2022
thomaspaulb
commented
Jul 17, 2022
thomaspaulb
commented
Jul 17, 2022
| ) { | ||
| resolve(pay_line.terminal_transaction_success); | ||
| // Stop the loop | ||
| clearInterval(timerId); | ||
| } | ||
| } | ||
| } | ||
| if (!got_response && retries > 30) { | ||
| // if after 30 seconds still no word about the status of the transaction, | ||
| // then consider it lost in space. Let user decide the status. |
There was a problem hiding this comment.
I'm not sure if this plays well with other drivers such as Telium, which may not return any status until there is a definite Approved or Cancelled - in that case 30 seconds may be too soon. Maybe this should be made configurable?
There was a problem hiding this comment.
Or we could just remove this, since the 'waiting for card' screen does show a 'Cancel' button, so the user is not stuck.
thomaspaulb
force-pushed
the
13.0-pos-payment-terminal-fixes
branch
from
62d3001 to
64d9bd8
Compare
thomaspaulb
changed the title
thomaspaulb
changed the title
ntsirintanis
pushed a commit
that referenced
this pull request
Dec 11, 2024
[FIX] use float_compare to compare floats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.